Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go instead of Node.js app in tests #1375

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Use Go instead of Node.js app in tests #1375

merged 3 commits into from
Apr 26, 2023

Conversation

silvestre
Copy link
Member

No description provided.

@silvestre silvestre added the allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. label Feb 3, 2023
@silvestre silvestre force-pushed the golang-test-app branch 2 times, most recently from 5e3593a to 1782744 Compare February 6, 2023 16:24
@silvestre silvestre force-pushed the golang-test-app branch 2 times, most recently from 169cf99 to 9cec452 Compare February 20, 2023 10:07
@silvestre silvestre marked this pull request as ready for review April 21, 2023 15:23
joergdw
joergdw previously requested changes Apr 24, 2023
View reviewed changes
src/acceptance/assets/app/go_app/internal/app/cpu.go Outdated Show resolved Hide resolved
src/acceptance/assets/app/go_app/internal/app/cpu.go Outdated Show resolved Hide resolved
src/acceptance/assets/app/go_app/internal/app/memory.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

@silvestre silvestre requested a review from joergdw April 25, 2023 13:12
@silvestre silvestre enabled auto-merge (squash) April 25, 2023 15:22
@silvestre silvestre dismissed joergdw’s stale review April 26, 2023 07:16

Requested changes have been applied.

@silvestre silvestre merged commit b237056 into main Apr 26, 2023
@silvestre silvestre deleted the golang-test-app branch April 26, 2023 07:43
@silvestre silvestre linked an issue Apr 26, 2023 that may be closed by this pull request
Some tests failing after upgrading to 9.0.1 #1059
Closed
@silvestre silvestre mentioned this pull request Apr 26, 2023
Closed
@fdalfons fdalfons mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalan316 asalan316 asalan316 approved these changes

@joergdw joergdw Awaiting requested review from joergdw

Assignees
No one assigned
Labels
allow-acceptance-tests This label needs to be added to enable the acceptance tests to run. bug chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests failing after upgrading to 9.0.1
3 participants
@silvestre @joergdw @asalan316