-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscaler basic auth optional #3044
Draft
asalan316
wants to merge
6
commits into
main
Choose a base branch
from
autoscaler-basic-auth-optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+493
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
added
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
skip-cleanup
and removed
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
labels
Jun 26, 2024
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
4 times, most recently
from
June 26, 2024 10:22
94c98bf
to
ff1d697
Compare
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
June 26, 2024 12:29
ff1d697
to
66e75e4
Compare
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
July 1, 2024 15:26
45fd841
to
65ceb1c
Compare
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
July 2, 2024 10:05
65ceb1c
to
d572bf4
Compare
asalan316
commented
Jul 5, 2024
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
July 5, 2024 13:03
d2f5607
to
cc4d0d9
Compare
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
2 times, most recently
from
July 5, 2024 16:06
e074764
to
7c99ad4
Compare
Quality Gate failedFailed conditions |
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
July 5, 2024 17:06
7c99ad4
to
95e096e
Compare
asalan316
commented
Jul 5, 2024
@@ -31,7 +31,7 @@ type Credential struct { | |||
|
|||
type CustomMetricsCredentials struct { | |||
*Credential | |||
URL string `json:"url"` | |||
URL string `json:"url,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore url in the json output if zero value for string exist e.g ""
asalan316
force-pushed
the
autoscaler-basic-auth-optional
branch
from
July 5, 2024 17:16
95e096e
to
82b7b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
allow-acceptance-tests
This label needs to be added to enable the acceptance tests to run.
skip-cleanup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make basic authentication when communicating with custom metrics optional.
A new parameter
credential_type
is introduced as part of the service binding request.valid values of
credential_type
arebinding-secret
andx509
Example Request
cf bind-service <APP_NAME> <AUTOSCLAER_SERVICE_NAME> -c "{ \"credential_type\": \"x509\", \"instance_min_count\": 1, \"instance_max_count\": 4, \"scaling_rules\": [{ \"metric_type\": \"memoryused\", \"breach_duration_secs\": 600, \"threshold\": 30, \"operator\": \"<\", \"cool_down_secs\": 300, \"adjustment\": \"-1\" }] }"
Sample Broker Response Output