This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
public api #263
Merged
public api #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey qibobo! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150287500 The labels on this github issue will be updated when the story is started. |
cdlliuy
reviewed
Aug 16, 2017
api/lib/config/setting.js
Outdated
| if (settings.publicPort < 1 || settings.publicPort > 65535) { | ||
| return {valid:false,message:"value of publicPort must between 1 and 65535"}; | ||
| } | ||
|
|
There was a problem hiding this comment.
how about add a check for public port != internal port ?
cdlliuy
reviewed
Aug 16, 2017
api/app.js
Outdated
| @@ -77,20 +101,35 @@ module.exports = function(configFilePath) { | |||
| }); | |||
| } | |||
|
|
|||
| var publicServer; | |||
| if(settings.publicTls){ | |||
| publicServer = https.createServer(publicOptions, app).listen(publicPort || 3002, function() { | |||
There was a problem hiding this comment.
how about using different default port?
|
@cdlliuy fixed. |
[#145833985]
[#145833985]
|
LGTM |
boyang9527
reviewed
Aug 18, 2017
api/lib/config/setting.js
Outdated
| return {valid:false,message:"publicPort must be a number"}; | ||
| } | ||
| if (settings.publicPort < 1 || settings.publicPort > 65535) { | ||
| return {valid:false,message:"value of publicPort must between 1 and 65535"}; |
|
this PR does not include the permission check with the oAuth token... I am assuming that one will be added later. |
|
@boyang9527 fixed. |
|
@boyang9527 will have another pr for oauth. |
|
LGTM |
boyang9527
approved these changes
Aug 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.