Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question on https://github.com/cloudfoundry/binary-buildpack/issues/18 #21

Closed
luisapace opened this issue Jul 6, 2018 · 5 comments
Closed

Comments

@luisapace
Copy link

luisapace commented Jul 6, 2018

Hi, I'm opening a new issue because I don't know how to reopen any closed issue (sorry for that).

In the:
#18

I read (as said by Stephen Levine):

"Everything in fixtures is test data that isn't included in the buildpack. Those versions don't exist, as you've noticed".

May I kindly ask you to please clarify that? what do you mean with "everything"? and what do you mean that isn't included in the buildpack? for example there is another "fixture" directory in the binary buildpack at https://github.com/cloudfoundry/binary-buildpack/tree/v1.0.17/fixtures.

Finally, that is valid for all the other buildpacks? I mean: is it a standard rule that what is in fixtures is test data that isn't included in the buildpack?

Thanks again.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158871368

The labels on this github issue will be updated when the story is started.

@sclevine
Copy link
Contributor

sclevine commented Jul 6, 2018

All of the contents in the fixtures directory in every Cloud Foundry buildpack is not included in the final buildpack artifact. It is made up test data that is only used to develop the buildpack. The references to dependencies in the fixtures directories are not references to real dependencies.

@luisapace
Copy link
Author

So, if I've understood well - for example - none of the all the gems included in the source code at https://github.com/cloudfoundry/ruby-buildpack/tree/v1.7.15/fixtures/rails3_mri_200/vendor/cache
will be present in the final buildpack so that nobody will be able to access/download their code at runtime when it will use the buildpack?

Thanks again.

@astrieanna
Copy link
Contributor

@luisapace That is correct. When we package buildpacks, the fixtures directory is not included.

@luisapace
Copy link
Author

luisapace commented Jul 9, 2018

This is for ALL directories with this name in ALL the buildpacks? because I see the name "fixtures" in a lot of positions, for example https://github.com/cloudfoundry/binary-buildpack/tree/master/src/binary/vendor/github.com/cloudfoundry/libbuildpack/fixtures

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants