add the ability to set the network property 'source/destination check' #38
Conversation
|
Hey fearoffish! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
| @@ -34,6 +34,7 @@ def create(agent_id, stemcell_id, resource_pool, networks_spec, disk_locality, e | |||
| instance.wait_for_running | |||
| instance.attach_to_load_balancers(resource_pool['elbs'] || []) | |||
| instance.update_routing_tables(resource_pool['advertised_routes'] || []) | |||
| instance.source_dest_check = resource_pool['source_dest_check'] || true | |||
There was a problem hiding this comment.
@fearoffish afraid you can't use the fallback operator here as false || true always evaluate to true. Your unit tests back this up as you set 'source_dest_check' => false at the top, yet every test expects allow(aws_instance).to receive(:source_dest_check=).with(true). Could you fix this and add tests for both the false and true cases?
There was a problem hiding this comment.
you can do resource_pool.fetch('source_dest_check', true)
|
@fearoffish neat idea, would also allow people to deploy NAT boxes with BOSH. Added a code comment inline. |
|
Fixed. Extra points for the beginner ruby error, right? :) |
|
Added an integration test: 3c7cb07 |
The ability to set the 'source/destination check' network property is useful for instances performing cross-VPC routing. This allows a resource pool property to set this, it defaults to 'true' which is the AWS default.