Fix failing copy_ami_driver tests #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvach
commented
Dec 4, 2023
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| Expect(*respSnapshots.Snapshots[0].Encrypted).To(BeTrue()) | ||
| Expect(*respSnapshots.Snapshots[0].KmsKeyId).To(Equal(destinationRegionKmsKeyId)) |
There was a problem hiding this comment.
Please note that we change the test expectation here.
We never managed to share an AMI with a single region kms key across regions. It's as well documented that this is not working.
After a discussion with @ramonskie it turned out that no one is using encrypted AMIs so far. Therefor we adapted the behaviour in a way that a multi region kms key need to be provided when copying encrypted AMIs across regions. Due to that we check the replicated destination key here.
Currently copy_ami_driver_test depends on the kms_driver_test since the kms_driver_test replicates a key that is used in the copy_ami_driver_test This can result in flakey tests.
mvach
commented
Dec 6, 2023
| @@ -58,7 +58,7 @@ var _ = Describe("KmsDriver", func() { | |||
|
|
|||
| It("replicates a given kms key to another region", func() { | |||
| driverConfig := resources.KmsReplicateKeyDriverConfig{ | |||
| KmsKeyId: multiregionKmsKeyId, | |||
| KmsKeyId: multiRegionKeyReplicationTest, | |||
There was a problem hiding this comment.
This test triggers the cleanup of the replicated key in line 81. That makes the private AMI tests in the copy_ami_driver_tests flakey. Therefore we have to separate the used multiregion kms keys here.
mvach
added a commit
to cloudfoundry/bosh-stemcells-ci
that referenced
this pull request
Dec 6, 2023
ramonskie
added a commit
to cloudfoundry/bosh-stemcells-ci
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.