Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loudly error when failing to make an AMI public #38

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Loudly error when failing to make an AMI public #38

merged 2 commits into from
Mar 27, 2024

Commits on Mar 20, 2024

  1. Loudly error when failing to make an AMI public 

    We published a light stemcell (Jammy 1.406) whose AMI in region
`eu-central-1` was not public, causing an error when a user tried to
deploy.

The problem was we never checked to make sure that our attempt to make
the AMI public succeeded.

With this commit, we now propagate any errors that occur when attempting
to make the AMI we publish public.

Signed-off-by: Brian Cunnie <brian.cunnie@broadcom.com>

[#184045754] Ensure the aws light stemcell builder catches errors when making AMIs public
    @klakin-pivotal @cunnie
    klakin-pivotal authored and cunnie committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    53cb14c View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Remove nolint check now that we are checking for error 

    Signed-off-by: Joseph Palermo <joseph.palermo@broadcom.com>
Co-authored-by: Joseph Palermo <joseph.palermo@broadcom.com>
    @klakin-pivotal @jpalermo
    klakin-pivotal and jpalermo committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8cb61f0 View commit details
    Browse the repository at this point in the history