Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-cloud-config does not offer the --named flag #542

Closed
friegger opened this issue Oct 4, 2019 · 6 comments · Fixed by cloudfoundry/bosh#2390, #600 or cloudfoundry/docs-bosh#774
Closed
Assignees

Comments

@friegger
Copy link
Contributor

friegger commented Oct 4, 2019

https://bosh.io/docs/cli-v2/#update-cloud-config does not support the --name flag. With this it cannot do everything that update-config can do. As mentioned in cloudfoundry/bosh#2209 (comment) this should actually be the case.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168946968

The labels on this github issue will be updated when the story is started.

@mfine30
Copy link
Contributor

mfine30 commented Oct 4, 2019

Hey @friegger I agree we should probably add that. It does feel like a good idea so that update-runtime-config and update-cloud-config match. That being said, I don't think update-cloud-config does anything special, so in theory bosh update-config --name NAME --type cloud would achieve the exact same result.

I still see value in this change to help reduce surprises to operators, but not an urgent must have.

@bosh-admin-bot
Copy link

This issue was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

@bosh-admin-bot
Copy link

This issue was closed because it has been labeled Stale for 7 days without subsequent activity. Feel free to re-open this issue at any time by commenting below.

@mvach
Copy link
Contributor

mvach commented Jun 8, 2022

Hi I'm currently working on that issue.

The director part: https://github.com/cloudfoundry/bosh/tree/update-cloud-config-with-name-param
The cli part: https://github.com/cloudfoundry/bosh-cli/tree/update-cloud-config-with-name-param

I didn't create PRs so far, since there is some more testing that need to be done

@mvach
Copy link
Contributor

mvach commented Jun 28, 2022

I created following PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment