GCS disable multipart upload #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 19, 2016 16:15
The initial impetus for this change is the fact that GCS, in "S3-compatibility mode", does not support multipart HTTP uploads. Rather than provide a configuration option for this, we decided to embed the logic internally using a blacklist of non-multipart-upload hosts. In this way, consumers of `s3cli` do not need to know to set some configuration when using GCS. [#126552613](https://www.pivotaltracker.com/story/show/126552613)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial impetus for this change is the fact that GCS, in
"S3-compatibility mode", does not support multipart HTTP uploads.
Rather than provide a configuration option, we decided to embed
the logic internally using a blacklist of non-multipart-upload hosts. In
this way, consumers of
s3clido not need to know to set someconfiguration when using GCS.
#126552613