Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that host style is not effect #25

Closed
wants to merge 1 commit into from

Conversation

xiaozhu36
Copy link
Contributor

@xiaozhu36 xiaozhu36 commented Nov 12, 2018

This PR aims to fix two issues:

  1. HostStyle is not effect
  2. Can not support China region and Non-China region at the same time when provider is alibaba cloud.

This PR does the two things:

  1. Re-set v2.HTTPRequest.Host when HostStyle is true. The prefect solution is aws-sdk-go PR
  2. Setting header date according to config region

@cfdreddbot
Copy link

✅ Hey xiaozhu36! The commit authors and yourself have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/161882697

The labels on this github issue will be updated when the story is started.

@xiaozhu36 xiaozhu36 changed the title Fix authentication failed error fix the issue that host style is not effect Nov 14, 2018
@bosh-admin-bot
Copy link

This pull request was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

@bosh-admin-bot
Copy link

This pull request was closed because it has been labeled Stale for 7 days without subsequent activity. Feel free to re-open this pull request at any time by commenting below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants