Accept server-side encryption options. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljfranklin @coreyti thoughts on testing this? |
|
Looks like most tests here are integration tests, so I would guess we'd want to add an integration test that PUTs a file with SSE, then checks the object metadata to verify that it's encrypted. If that makes sense, I can add that test. |
|
Bump. Should I write that integration test? |
|
@jmcarp that would be great if that's possible. (sorry been at cf summit...) |
|
Added an integration test in 6617dd7. Looking forward to feedback--I'm happy to revise as needed. |
|
Story https://www.pivotaltracker.com/story/show/120780091 at the top of the backlog. |
|
@jmcarp Thanks, the PR looks great! Just merged this onto develop. Once our CI goes through I'll open a PR to bump the s3cli the ships with Bosh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept
ServerSideEncryptionandSSEKMSKeyIDconfig options and pass toUpload. Since these options have type*string, uploading works as normal if the options aren't set.[Resolves #5]