Changes for building a ppc64le stemcell for Power8 Ubuntu LE #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wer-3029-stemcell
…stemcell-no-gccgo
|
Hey hashmap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
| @@ -36,7 +36,7 @@ def agent_stages | |||
| :bosh_micro_go, | |||
| :aws_cli, | |||
| :logrotate_config, | |||
| ] | |||
| ].reject{ |s| RbConfig::CONFIG['host_cpu'] == 'powerpc64le' and s == :bosh_micro_go } | |||
There was a problem hiding this comment.
(Hmm. I lost my prev comment...)
Given that we skip bosh_micro_go stage we can also skip bosh_ruby which also means we dont have to make it work on ppc. Wdyt?
There was a problem hiding this comment.
You mean we don't need to patch packages like ruby and yaml, sounds good. I thought it may be required for smth else.
| # needed to remove rsyslog-mmjsonparse on ppc64le | ||
| # because of this issue https://gist.github.com/allomov-altoros/cd579aa76f3049bee9c7 | ||
| if [ `uname -m` == "ppc64le" ]; then | ||
| pkg_mgr install "rsyslog rsyslog-relp rsyslog-gnutls" |
There was a problem hiding this comment.
could always run pkg_mgr install "rsyslog rsyslog-relp rsyslog-gnutls" and then install conditionally rsyslog-mmjsonparse
| @@ -46,6 +46,11 @@ def manifest(disk_format) | |||
| end | |||
|
|
|||
| def manifest_cloud_properties(disk_format, infrastructure, stemcell_name) | |||
| architecture = 'x86_64' | |||
There was a problem hiding this comment.
Perhaps replace with the ternary operator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support of stemcell creation on ppc64le platform on Ubuntu. Main changes:
stemcell name includes arch name on ppc
spec exclusion tag 'exclude_on_ppc64le'
2 partitions on ppc, first is PReP (required for boot)
bosh_micro_go agent step is disabled
system_ixgbevf module is disabled
ppc64le ubuntu repos are added
news assets config.guess and config.sub, also code which patches some packages with outdated config.guess and config.sub, otherwise 'configure' tool can't recognize ppc64le hardware platform
changes in GRUB configuration
rsyslog 8 is not supported yet