Resolve blobstore logging warning [#174649741] #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174879650 The labels on this github issue will be updated when the story is started. |
cunnie
pushed a commit
that referenced
this pull request
Mar 25, 2021
We bump nginx because the versions of nginx 1.19.5+ include a flag (`-e`) that eliminates a harmless-but-concerning log message: ``` nginx: [alert] could not open error log file: open() "/var/vcap/packages/nginx/logs/error.log" failed (30: Read-only file system) ``` [#176851693] [#2279] Signed-off-by: Brian Cunnie <bcunnie@vmware.com>
cunnie
pushed a commit
that referenced
this pull request
Mar 25, 2021
- Place `.pid` file in bpm-friendly directory
- Use the `-e` flag (for error file) in lieu of `-p`; it reduces the
need for the following gyrations to make things work:
- Don't create directories or links as part of `pre-start`; they are no
longer necessary.
- Don't add additional volumes permissions; we don't use them
[#176851693]
[#2279]
Signed-off-by: Brian Cunnie <bcunnie@vmware.com>
|
@rkoster Thanks for the excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
The blobstore log contained a warning which has confused people while debugging other blobstore issues.
The log line:
This was caused by the fact that the default prefix
/var/vcap/packages/nginxwas not writable.By changing the prefix (using the
-pflag) to/var/vcap/data/blobstore(which is writable), this issue was resolved.This change also increases the log level to include warning.
Which resulted in the following log line:
This was fixed by increasing the open_files limit via bpm to 8192.
While working on this I also noticed nginx was running in daemon mode (which makes sense under bpm).
However it still had a pid location configured which seemed unnecessary.
Please provide contextual information.
https://www.pivotaltracker.com/story/show/174649741
What tests have you run against this PR?
Manual testing to verify warnings are ending up in the correct file:
This warning should not be displayed anymore after this PR is merged since the limit in bpm is increased.
Lowering the limit manually in the bpm config and restarting the blobstore should work.
How should this change be described in bosh release notes?
Improved blobstore error logging
Does this PR introduce a breaking change?
No