Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description for director's job properties #2326

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

bgandon
Copy link
Contributor

@bgandon bgandon commented Sep 30, 2021

What is this change about?

Here we improve the description for some director's job properties related to compiled package cache

Please provide contextual information.

The property provider is actually unnecessary when blobstore_path is provided.

What tests have you run against this PR?

Unit tests for the BOSH Release templates are passing, as executed with (cd src && bundle exec rspec ../spec).

How should this change be described in bosh release notes?

These minor changes should not be necessary to appear in the release notes.

Does this PR introduce a breaking change?

No, this is definitely related to documentation only.

Tag your pair, your PM, and/or team!

Co-Authored-By: @OliverMautschke

Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to miss some context

jobs/director/spec Show resolved Hide resolved
@rkoster rkoster self-assigned this Oct 13, 2021
@bosh-admin-bot
Copy link

This pull request was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

@rkoster
Copy link
Contributor

rkoster commented Nov 4, 2021

Thanks @bgandon

@rkoster rkoster merged commit ce987b6 into master Nov 4, 2021
@rkoster rkoster deleted the improve-job-props-docs branch November 4, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants