Use director proxy_timeout also for metrics server #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkoster
requested review from
a team,
beyhan and
lnguyen
and removed request for
a team
|
Thanks! @ionphractal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Use proxy_timeout also for metrics server nginx configuration.
Please provide contextual information.
Depending on the size of the environment, the amount of metrics produced also increases and metrics gathering may take more than the default 60s proxy_read_timeout after which nginx responds with "504 Gateway Time-out".
What tests have you run against this PR?
After applying the change to a director the described symptom (504 Gateway Time-out)...
How should this change be described in bosh release notes?
Use director proxy_timeout also for metrics server
Does this PR introduce a breaking change?
No.
Tag your pair, your PM, and/or team!
@benjaminguttmann-avtq