Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coverage report generation when running unit tests on ci #2439

Merged
merged 3 commits into from May 2, 2023

Conversation

rkoster
Copy link
Contributor

@rkoster rkoster commented Apr 28, 2023

What is this change about?

This PR restores simplecov code coverage reporting when running unit tests in ci.
In the past, this must have worked because the required configuration is already in place, however, the simpelcov gem itself was no longer included in the Gemfile.

Please provide contextual information.

At VMware we have an internal ask to report test coverage for components we ship, also from an OSS point of view knowing our test coverage is a best practise.

What tests have you run against this PR?

Have tested locally using:

docker run \
       --mount type=bind,source="$(pwd)",target=/workspace/bosh-src \
       --workdir /workspace \
       --env DB=sqlite \
       --env RUBY_VERSION=3.2.0 \
       --env COVERAGE=true \
       bosh/integration bosh-src/ci/tasks/test-unit.sh

Which matches the test-unit.yml task invocation

@rkoster rkoster requested review from a team, aramprice and ragaskar and removed request for a team April 28, 2023 08:40
Copy link
Member

@aramprice aramprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

@aramprice
Copy link
Member

🤔 is anyone consuming this coverage output?

If not is it worth adding this code, configuration, and run-time back in?

@ragaskar
Copy link
Contributor

Didn't clone + test but LGTM.

@jpalermo
Copy link
Member

Adding some new gems, maybe now is a good time to enable git lfs for the vendor folder

@rkoster
Copy link
Contributor Author

rkoster commented May 2, 2023

Adding some new gems, maybe now is a good time to enable git lfs for the vendor folder

Done: dac1f51

@rkoster rkoster merged commit e147fec into main May 2, 2023
1 check passed
@rkoster rkoster deleted the simpelcov branch May 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants