Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance/update java build integration image #2442

Merged
merged 2 commits into from May 9, 2023
Merged

Maintenance/update java build integration image #2442

merged 2 commits into from May 9, 2023

Conversation

nouseforaname
Copy link
Contributor

Update the JDK in use to a newer build. The one currently in use is several years old

@nouseforaname
update jdk8 to latest build
7b5a71f
@nouseforaname
set the JAVA_HOME without knowing version
92c8827 
this removes the necessity to update the file name when changing the
version of the jdk
@nouseforaname
Copy link
Contributor Author 

openjdk version "1.8.0_372"
OpenJDK Runtime Environment (Zulu 8.70.0.23-CA-linux64) (build 1.8.0_372-b07)
OpenJDK 64-Bit Server VM (Zulu 8.70.0.23-CA-linux64) (build 25.372-b07, mixed mode)```

rkoster
rkoster approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@rkoster rkoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of interest, where did you encounter this image in the wild? Assuming you did not encounter it while working on the BOSH director.

@nouseforaname
Copy link
Contributor Author

cryo work, there's a task that needs the ecosystem tooling to run (among other things) credhub..

ramonskie
ramonskie approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@ramonskie ramonskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nouseforaname nouseforaname merged commit e3647ed into main May 9, 2023
1 check passed
@aramprice aramprice deleted the maintenance/update-java-build-integration-image branch January 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoster rkoster rkoster approved these changes

@ramonskie ramonskie ramonskie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nouseforaname @rkoster @ramonskie