Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support instance group tags #2448

Merged
merged 1 commit into from Jun 23, 2023

Conversation

a-hassanin
Copy link
Contributor

@a-hassanin a-hassanin commented May 31, 2023

What is this change about?

The change allows to configure instance group specific tags, by allowing the user to include tags under <instance_group> -> tags in the manifest.

These tags can be configured as follows:

instance_groups:
- name: <instance_group>
  tags:
    tag1: value1
    tag2: value2

These tags are merged with the instance plan tags during VM creation and have higher priority when there are keys which already exist. These tags can be useful under many circumstances, for example, in a large organisation, it makes identifying teams responsible for different instances easier. Also, This feature removes the necessity of including tags for the entire deployment when such tags aren't needed for all the involved instance groups.

Please provide contextual information.

This PR builds on the feedback given in: #2444

What tests have you run against this PR?

bosh-director unit tests, dev-release testing on development environments

How should this change be described in bosh release notes?

Support instance group specific tags.

Does this PR introduce a breaking change?

No breaking change, since this PR just supports additional functionality of supporting instance tags.

Tag your pair, your PM, and/or team!

@anshrupani @mvach

@a-hassanin a-hassanin force-pushed the support-instance-group-tags branch 2 times, most recently from 470fadd to 1d56dc0 Compare June 2, 2023 07:02
@a-hassanin a-hassanin marked this pull request as ready for review June 2, 2023 07:09
Co-authored-by: Ansh Rupani <ansh.rupani@sap.com>
@a-hassanin a-hassanin force-pushed the support-instance-group-tags branch from 1d56dc0 to f74f02c Compare June 2, 2023 07:54
@a-hassanin
Copy link
Contributor Author

@rkoster Thursday is a public holiday in Germany, can you please have a look at this enhanced PR and share your feedback?
Thanks,

Cheers,
Ahmed

@rkoster rkoster requested review from a team, danielfor and klakin-pivotal and removed request for a team June 7, 2023 14:08
@rkoster
Copy link
Contributor

rkoster commented Jun 8, 2023

@a-hassanin would you be so kind as to also create a PR to update: https://github.com/cloudfoundry/docs-bosh/edit/master/content/manifest-v2.md

@beyhan beyhan merged commit 95b94f7 into cloudfoundry:main Jun 23, 2023
1 check passed
@a-hassanin a-hassanin deleted the support-instance-group-tags branch June 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants