Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
The change allows to configure instance group specific tags, by allowing the user to include tags under <instance_group> -> tags in the manifest.
These tags can be configured as follows:
These tags are merged with the instance plan tags during VM creation and have higher priority when there are keys which already exist. These tags can be useful under many circumstances, for example, in a large organisation, it makes identifying teams responsible for different instances easier. Also, This feature removes the necessity of including tags for the entire deployment when such tags aren't needed for all the involved instance groups.
Please provide contextual information.
This PR builds on the feedback given in: #2444
What tests have you run against this PR?
bosh-director unit tests, dev-release testing on development environments
How should this change be described in bosh release notes?
Support instance group specific tags.
Does this PR introduce a breaking change?
No breaking change, since this PR just supports additional functionality of supporting instance tags.
Tag your pair, your PM, and/or team!
@anshrupani @mvach