Fixes Postgres 10 -> 15 upgrade with 9.4 db dir #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit * Fixes the upgrade case where a customer upgraded from Postgres 9.4 to Postgres 10, and then chose to upgrade to Postgres 15. The previous logic expected that when a PG 9.4 directory was present, then a PG 10 AND a PG 13 directory also HAD to be present, or else it would fail the pre-start script early. This commit corrects that logic. * Also refactors the logic that checks for older (and unsupported) PG versions, and also the logic that upgrades from supported PG versions to the latest version. Should we ever find ourselves needing to obsolete a version of Postgres, or add a new one, hopefully this rewrite will make modifying this script easier. [#185335638] Signed-off-by: Brian Upton <bupton@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
[#185335638]
NOTE: The refactored logic has been "mocked" out and tested, so we're confident in its correctness.
@ystros