Enable support for verify-ca SSL mode for cases when hostname verification is not possible/required #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ication is not possible/required
jpalermo
requested review from
a team,
ragaskar and
ystros
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Bosh docs claim that bosh provides support for the director DB TLS config property
skip_host_verify, but unfortunately there was not implementation in the code or support in the director specs template. This PR provides support for this property, enabling another SSL verification mode (verify-ca for postgres, verify_ca for mysql2). This will especially be useful for enabling TLS communication with GCP databases, where hostname verification is currently not possible.What tests have you run against this PR?
Ran the director unit tests and verified the usage of a dev-release with this feature on a development environment.
How should this change be described in bosh release notes?
Provide support for verify-ca SSL mode by enabling
skip_host_verifydirector DB TLS config.Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@Malsourie