enable metrics for deploy config #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoehler
force-pushed
the
create-metrics-for-deploy-config
branch
from
448d876
to
1874004
Compare
AttilaAlmasi
approved these changes
Dec 18, 2023
rkoster
requested review from
a team,
aramprice and
klakin-pivotal
and removed request for
AttilaAlmasi and
a team
ystros
reviewed
Jan 2, 2024
beyhan
approved these changes
Jan 11, 2024
|
Thanks! @fmoehler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
We introduced deploy configs with Bosh CLI v7.5.0+. As this could potentially lead to unwanted deploy flags if the config is forgotten/enabled too long, we introduce a metrics that returns 1 in case a deploy config is uploaded.
Please provide contextual information.
https://github.com/cloudfoundry/docs-bosh/blob/master/content/deploy-config.md
What tests have you run against this PR?
Create Dev Release and checked the response of the metrics server
How should this change be described in bosh release notes?
The default metrics now return if a deploy config was uploaded or not to avoid it being forgotten
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@AttilaAlmasi