New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blobstore clients supports PUT headers #2494
Conversation
Hi @jpalermo, |
When putting blobs via signed urls to Azure Blobstore, then the mandatory header 'x-ms-blob-type' has to be set to value 'blockblob'.
a6105af
to
08d2216
Compare
I haven't looked at it super closely, but I wonder if we can just combine all the headers in the blobstore client classes and rename |
Hi @jpalermo, |
After incorporating the feedback we started validating the PR in our local test environment. |
198e085
to
fdafcbb
Compare
We successfully finished testing this PR on our azure landscape. |
Hi @jpalermo, hi @aramprice, |
src/bosh-director/lib/bosh/blobstore_client/azurestoragecli_blobstore_client.rb
Show resolved
Hide resolved
src/bosh-director/spec/unit/deployment_plan/stages/package_compile_stage_spec.rb
Show resolved
Hide resolved
Hi @aramprice, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Follow up to PR #2494 Signed-off-by: Joseph Palermo <joseph.palermo@broadcom.com>
What is this change about?
When putting blobs via signed urls to Azure Blobstore, then the mandatory header 'x-ms-blob-type' has to be set to value 'blockblob'. Therefore we add a mechanism to support PUT headers.
We are doing it just the same why like encryption headers can be set for GCS.