Switch metrics server from thin to puma #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
approved these changes
Feb 20, 2024
rkoster
requested review from
a team,
mvach and
bgandon
and removed request for
a team
This was referenced Feb 22, 2024
Signed-off-by: Aram Price <pricear@vmware.com>
Signed-off-by: Brian Upton <bupton@vmware.com>
The Director already uses Puma in production mode, but was still using Thin for a local file server in the integration specs. This converts that test server to Puma as well. Additionally, the bosh-nats-sync gem declared a dependency on Thin that it never used. Signed-off-by: Aram Price <pricear@vmware.com>
ystros
force-pushed
the
use-puma-for-metrics-server-#185264086
branch
from
a7eddab
to
85b202e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to get rid of EventMachine, which has been unmaintained for some time, we are switching from using Thin web server (which is based on EventMachine) to Puma instead.
Since there don't seem to be unit specs for this bin script, we applied our patch to a running director to ensure that the metrics server comes up as expected.
See also #2499, #2500 for more removals of EventMachine.