Remove out-of-date licenses for ruby gems #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The license file, in addition to listing the license for the project, was listing the licenses for each gem in use. However, this list has not been updated since 2016, and no longer accurately reflects the gems and versions in use.
mvach
approved these changes
Feb 20, 2024
aramprice
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license file, in addition to listing the license for the project, was listing the licenses for each gem in use. However, this list has not been updated since 2016, and no longer accurately reflects the gems and versions in use.
Additional context:
Most Cloud Foundry projects don't list licenses of dependencies in this manner as part of the main license file, so removal seemed like the best course of action. Alternatively, we could update the file when gems are changed in order to keep the file up-to-date and accurate.