Linting and code cleanup #2504
Merged
Linting and code cleanup #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramprice
force-pushed
the
linting-and-code-cleanup
branch
2 times, most recently
from
0c08808
to
7ca7807
Compare
... since the PR mentioned in the comment introducing the require has been merged
aramprice
force-pushed
the
linting-and-code-cleanup
branch
from
7ca7807
to
60e3e8f
Compare
There are three places where `#pretty_inspect` is used in the bosh-director
- the value is in specs
Update specs to have spec-specific constants defined which are (re)injected into the `Bosh::Director` namespace, rather than defining a `Models` constant in each. Note the redefinition and `alias` of `Kernel#requre` in each spec uses a distinct method name so as not to conflicit with eachother.
`a_collection_containing_exactly` is an alias for `contain_exactly`
aramprice
force-pushed
the
linting-and-code-cleanup
branch
from
66a9d2e
to
f1bce6a
Compare
Addresses: ``` WARNING: Using the `raise_error` matcher without providing a specific error or message risks false positives, since `raise_error` will match when Ruby raises a `NoMethodError`, `NameError` or `ArgumentError`, potentially allowing the expectation to pass without even executing the method you are intending to call. ```
in the case of `spec/assets/uaa_config/asymmetric/uaa.yml` the last `hm:` key containing the most information was retained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: it may be easiest to review this change on a per-commit basis, rather than as one large change as each commit is small and has a (hopefully) helpful commit message.
What is this change about?
Cleaning up some linting, code clarity, and spelling issues.
Please provide contextual information.
This PR is a holding place for issues discovered in #2501 which should be addressed. I pulled them out here so as not to complicate the other PR.
What tests have you run against this PR?
✅
be rake fly:unit✅
DB=mysql DB_VERSION=5.7 be rake fly:unit✅
DB=mysql DB_VERSION=5.7 be rake fly:integrationHow should this change be described in bosh release notes?
Does this PR introduce a breaking change?
No.