Ensure Health Monitor HTTP connections are closed #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When EventMachine was removed from Health Monitor in favor of async-http, it neglected to explicitly close the Async::Http::Client objects. This results in connections to the Director on port 25555 to constantly accumulate and remain in a CLOSE_WAIT state. This can result in problems with NATS, such as the bosh-nats-sync process being unable to connect to the Director to get a list of valid clients.
aramprice
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
When EventMachine was removed from Health Monitor in favor of async-http, it neglected to explicitly close the Async::Http::Client objects. This results in connections to the Director on port 25555 to constantly accumulate and remain in a CLOSE_WAIT state. This can result in problems with NATS, such as the bosh-nats-sync process being unable to connect to the Director to get a list of valid clients.
Fixes #2509
What tests have you run against this PR?
health_monitorprocess. Observed HM logs and open connections withnetstatduring normal operation + when the resurrector plugin was triggered.