(Deployment-Wise) Retention Period for Scheduled Task Cleanup #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
a-hassanin
requested changes
May 15, 2024
Malsourie
force-pushed
the
retention-period
branch
from
e905dcd
to
35c5cf3
Compare
rkoster
reviewed
May 16, 2024
|
Still under testing |
Malsourie
force-pushed
the
retention-period
branch
from
3c68779
to
93236e5
Compare
|
Testing done on dev landscape |
lnguyen
requested changes
May 20, 2024
Done |
rkoster
reviewed
May 23, 2024
| @@ -1,20 +1,23 @@ | |||
| require 'spec_helper' | |||
| require 'fakefs/spec_helpers' | |||
| require 'bosh/director/api/task_remover' | |||
| require 'pry-byebug' | |||
There was a problem hiding this comment.
Could you remove this line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
Currently the debug logs of bosh tasks are cleaned up by ScheduledTasksCleanup module. We can configure the crontab schedule and max_tasks for the job. But the max_tasks is dependent on the platform size and hard to determine.
Describe the solution you'd like
During administration we think that it makes more sense that we have another config parameter retention_period for the job. The scheduled job will always delete the logs if the task is out dated.
Please provide contextual information.
Issue #2508
What tests have you run against this PR?
Unittests in bosh/src/bosh-director
Tested on a dev landscape
How should this change be described in bosh release notes?
Implement the (Deployment-Wise) Retention Period for Scheduled Task Cleanup
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@fearoffish