New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased Version of Director blobstores for swift #521
Conversation
…factor of the director tests to reduce confusing duplication
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: http://www.pivotaltracker.com/story/show/65820924 |
#508 was recently merged to support S3 compatible blobstores. Would you be able to support swift as an S3 provider with the new blobstore.use_ssl, blobstore.port and blobstore.host properties? |
As per the conversation on #508 the additional configuration options that are supported by S3 and compatible blobstores are not being passed through (only host, port, ssl, or endpoint if you look at PR #516 ) so the additional options for swift or hp that are in this PR are not currently supported. If there are plans in the works to refactor so generic blobstore options could be passed in and properly added to the director config I would be happy to help - would you be open to such a pull request is there a PT ticket or issue for that? |
Rene - what's the advantage of providing 2 different ways to be pass the On Fri, Feb 14, 2014 at 2:15 PM, Eric Malm notifications@github.com wrote:
-David Stevenson |
@rboshman (@dsboulder?): Did you mean to make your endpoint comment on the #516 thread? If so, we definitely agree that the extra option is potentially confusing and we have some reservations about the logic in parsing out the host, port, and scheme. In particular, it could end up mixing and matching fields, and it doesn't provide a correct default if the endpoint URI is malformed. |
For reference to anyone - we've been trying to get a PR like this into BOSH for 5 mths (since #450). |
We have decided for now to only support swift through its S3 compatible api. Closing. |
I've squashed the history from Dr. Nic's changes from PR #450 and mine as requested in PR #520