Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec description for cc.default_quota_definition wrong #20

Closed
anEXPer opened this issue Jul 11, 2016 · 3 comments
Closed

Spec description for cc.default_quota_definition wrong #20

anEXPer opened this issue Jul 11, 2016 · 3 comments
Labels

Comments

@anEXPer
Copy link
Member

anEXPer commented Jul 11, 2016

The spec files for the various CC jobs all reference cc.default_quota_definition and give the description as "Local to use a local (NFS) file system. AWS to use AWS.".

This is obviously not correct, and should be improved to be meaningful.

Some useful context: the spiff-based manifest-generation approach has reduced people's reliance on spec files. I suspect that as we move away from it (and are thus trying to configure releases based on the spec files themselves), more issues with the legibility and accuracy of spec files will tend to arise.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/126081689

The labels on this github issue will be updated when the story is started.

@ameowlia
Copy link
Member

ameowlia commented Jul 13, 2016

Hi @JesseTAlford,

We fixed this in commit b32db09. The spec description is now

The name of the quota definition CC will fallback on for org and space limits from the list of quota definitions

If you feel that your issue has been resolved, please go ahead and close it.

Thanks,
@adowns01 && @youreddy

@aashah
Copy link
Contributor

aashah commented Dec 10, 2016

Since there hasn't been any activity, I'm going to close this issue. Please feel free to re-open the issue if there's further information, or if we can help with anything else for this!

@aashah aashah closed this as completed Dec 10, 2016
capi-bot added a commit that referenced this issue Sep 20, 2023
…/tps

Bump src/code.cloudfoundry.org/cc-uploader
  dependabot[bot]:
     Bump github.com/onsi/ginkgo/v2 from 2.12.0 to 2.12.1 (#20)
Bump src/code.cloudfoundry.org/tps
  dependabot[bot]:
     Bump github.com/onsi/ginkgo/v2 from 2.12.0 to 2.12.1 (#37)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants