Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-namespace release_level_backup property #58

Closed
flangewad opened this issue Sep 26, 2017 · 6 comments
Closed

un-namespace release_level_backup property #58

flangewad opened this issue Sep 26, 2017 · 6 comments

Comments

@flangewad
Copy link
Contributor

Thanks for submitting an issue to capi-release. We are always trying to improve! To help us, please fill out the following template.

Issue

un-namespace release_level_backup property

Context

The release_level_backup property here: https://github.com/cloudfoundry/capi-release/blob/develop/jobs/bbr-cloudcontrollerdb/spec#L19 is currently namespaced with cloudcontroller (job name), probably because it was modelled after the bbr exemplar release.

We (bbr) have recently learned that the convention for new job-level properties is for there not to be any namespacing, so we've updated our exemplar release. Could you un-namespace the release_level_backup property in your release?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151439960

The labels on this github issue will be updated when the story is started.

@zrob
Copy link
Contributor

zrob commented Oct 3, 2017

Resolved in #57

@tinygrasshopper
Copy link
Contributor

@zrob there are other unnamespaced job specs in the capi-release
For example:

cloud_controller.release_level_backup:

cloud_controller.release_level_backup:

https://github.com/cloudfoundry/cloud_controller_ng/blob/master/bosh/jobs/cloud_controller_ng/spec#L861

Can you please re-open this issue?

@tcdowney
Copy link
Member

tcdowney commented Oct 6, 2017

@Gerg we're going to reopen this. It's analogous to #57, but not the same so we should do it.

@tcdowney tcdowney reopened this Oct 6, 2017
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151765180

The labels on this github issue will be updated when the story is started.

@Gerg
Copy link
Member

Gerg commented Oct 11, 2017

Theses properties will no longer be namespaced in capi-release 1.44.

@Gerg Gerg closed this as completed Oct 11, 2017
ari-wg-gitbot pushed a commit that referenced this issue Apr 7, 2024
Bump src/code.cloudfoundry.org/tps
  dependabot[bot]:
     Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 (#58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants