expose internal_route_vip_range as link #116
Conversation
[#162515686] Signed-off-by: Alex Standke <astandke@pivotal.io>
|
✅ Hey ameowlia! The commit authors and yourself have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/162746053 The labels on this github issue will be updated when the story is started. |
|
wow great change! |
cf-gitbot
added
scheduled
in progress
delivered
and removed
unscheduled
scheduled
in progress
labels
| @@ -103,6 +103,10 @@ provides: | |||
| - cc.internal_service_hostname | |||
| - cc.tls_port | |||
| - cc.mutual_tls.ca_cert | |||
| - name: cloud_controller_networking_info | |||
There was a problem hiding this comment.
Can we tweak the name a bit to make it more clear that this is for container networking and not general "I want to talk with the Cloud Controller" networking -- I've seen this cause confusion in the past with some of our links and their consumers.
Maybe something like:
cloud_controller_container_networking_infocloud_controller_app_networking_infocloud_controller_runtime_networking_info- Something even better 🥇
|
I think this link makes a lot of sense, but I'd like for it to be renamed so that consumers have a better idea of what kind of networking we're talking about here. Thanks! |
|
Thanks for your review! We don't consume the link yet because we were waiting on y'all to merge. Would it be easier for you guys to change the name real quick? That way we don't have to go through the PR flow again. |
This will make the intent of the link more clear that it's to be used for container networking related properties See PR #116 for more information. [finishes #162746053]
[#162515686]
Signed-off-by: Alex Standke astandke@pivotal.io
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:Expose
internal_route_vip_rangeas bosh linkWe wanna use it so it's only configured in one place (and not hardcoded 😐)
Nada
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite