Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that job is unmonitored before monitoring it again #202

Conversation

philippthun
Copy link
Member

In case the monitoring is triggered before the unmonitoring finished, the jobs remain in an unmonitored state. Make use of the helper function monit_unmonitor_job from monit_utils.sh as it waits until unmonitoring succeeded. Add monit_monitor_job function to monit_utils.sh.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

In case the monitoring is triggered before the unmonitoring finished,
the jobs remain in an unmonitored state. Make use of the helper function
'monit_unmonitor_job' from monit_utils.sh as it waits until unmonitoring
succeeded. Add 'monit_monitor_job' function to monit_utils.sh.

Co-authored-by: Aftab Alam <81828613+iaftab-alam@users.noreply.github.com>
@MarcPaquette MarcPaquette self-assigned this Oct 4, 2021
Copy link
Contributor

@MarcPaquette MarcPaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code. Seems like a clear case for deduplication. Tested it in a BOSH-lite lab. Unmonitored and monitored the affected monitor services, noted behavior to be correct.

@MarcPaquette MarcPaquette merged commit 1fb8f22 into cloudfoundry:develop Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants