Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export location of stacks.yml for migrations #75

Merged
merged 1 commit into from Feb 7, 2018

Conversation

idoru
Copy link
Contributor

@idoru idoru commented Jan 22, 2018

Signed-off-by: Dave Goddard dave@goddard.id.au

Thanks for contributing to the capi_release. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Provide an environment variable during database migrations which exposes the location of the stacks.yml config file.

  • An explanation of the use cases your change solves
    A migration which needs to alter data to include the default stack in some situations has no reliable way of identifying the default stack. If, however, the location of the CC's stacks.yml file is known, a migration can read it to find out the default stack.

  • Links to any other associated PRs
    Used to support migration in the following cloud_controller_ng PR

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

Signed-off-by: Dave Goddard <dave@goddard.id.au>
@cfdreddbot
Copy link

Hey idoru!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154527476

The labels on this github issue will be updated when the story is started.

@ericpromislow
Copy link
Contributor

Nothing is currently using STACKS_YML. I'm wondering if we should delay merging this in until something else is using it.

@idoru
Copy link
Contributor Author

idoru commented Feb 7, 2018

@ericpromislow yes, the first use case is in the cloud_controller_ng PR so merging this should probably be co-ordinated with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants