Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add isolated tcprouting tests with a standalone option #478

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

geofffranks
Copy link
Contributor

@geofffranks geofffranks commented Sep 10, 2021

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Re-implements the #474 to play nicer with other environments. Adds a retargeting step in isolation segment after each calls to ensure other tests running get targeted to the correct space. Enables testing of TCP routing to isolated diego cells.

Please provide contextual information.

Re-implements #474

What version of cf-deployment have you run this cf-acceptance-test change against?

latest

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

New property (optional, default off) to run include_tcp_isolation_segments. If enabled, requires include_isolation_segments and isolation_segment_name

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

CATs validates the proper configuration of isolated diego-cells in conjunction with a shared tcp router. It's best to test this in a scope responsible for the shipped configuration of both components.

How should this change be described in cf-acceptance-tests release notes?

Enables optional testing of TCP routing on isolation-segments via the include_tcp_isolation_segments config property.

How many more (or fewer) seconds of runtime will this change introduce to CATs?

300s when enabled

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • [ x ] Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@davewalter
Copy link
Member

Thanks for the updated PR @geofffranks! Looks good.

@davewalter davewalter merged commit 830d9e1 into cloudfoundry:develop Sep 10, 2021
CF Acceptance Tests automation moved this from To do to Done Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants