-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: BBL_STATE_DIR calculates full(er) path #25
Comments
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150113066 The labels on this github issue will be updated when the story is started. |
It looks like the critical line here is:
Essentially, our Concourse task would allow users to set their BBL_STATE_DIR to be relative to the In that case, what does |
@evanfarrar Hey, any updates on this? |
Hey, sorry I missed this: The |
Hey @evanfarrar. This sounds reasonable. I've updated the story: Title: Acceptance Criteria:
How does that look? |
I have not answered this in forever but, that looks great. |
Yo @evanfarrar, do we still need to do this since the release of bbl 5? If so, I'll prioritize it. |
Hey, I'm going to close this out since I don't think we need to do this after all. Feel free to re-open it if you think this would still be valuable. |
BBL is considering adding a
BBL_STATE_DIR
flag to mirror the functionality--state-dir
flag. We actually tried shipping it, and then noticed in pipelines that this broke pipelines because of the process you follow, simplified like so:Sure: we could pick a different name, or you could pick a different name, but I think in the long run it's a little more intuitive for people looking at the concourse task if all BBL_ are environment variables that BBL understands. For instance, I can check out my bbl-states repo, cd to that repo, set the vars I use in my concourse YML, and just
bbl up
. So my team has proposed this change as an example of a way that you can retain the nameBBL_STATE_DIR
and have a process that would be compatible with BBL before the change and after the change. Then long after the change you can elect at some time in the future to justcd bbl-states
and allow BBL_STATE_DIR to be implicitly passed to bbl.The text was updated successfully, but these errors were encountered: