Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is uaa.login.client_secret unnecessary? #85

Closed
geofffranks opened this issue Mar 3, 2017 · 3 comments
Closed

Is uaa.login.client_secret unnecessary? #85

geofffranks opened this issue Mar 3, 2017 · 3 comments

Comments

@geofffranks
Copy link
Contributor

The job properties for the UAA in cf-deployment.yml includes a uaa.login.client_secret property, but that is no longer a property listed in the UAA spec, and looks to have been removed in cloudfoundry/uaa-release@a33a1f3

Should this be removed from the manifest, and replaces with a login client defined in uaa.clients? Is the login client no longer required in uaa.clients either?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/141038853

The labels on this github issue will be updated when the story is started.

@dsabeti
Copy link
Contributor

dsabeti commented Mar 4, 2017

Hey @geofffranks. Great find. Thanks for pointing this out. I'll prioritize this story.

@dsabeti
Copy link
Contributor

dsabeti commented Apr 19, 2017

We've made the fix and accepted the story, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants