refactor add-otel-collector ops file #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
previously approved these changes
Aug 10, 2023
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
mkocher
force-pushed
the
otel-exporters-vars
branch
from
5787c63
to
cbe2381
Compare
ctlong
previously approved these changes
Aug 10, 2023
|
Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀 |
- accept variable to make it easier to provide on the command line or vars file - provide example vars file which exports metrics to a file on disk Signed-off-by: Carson Long <lcarson@vmware.com> Signed-off-by: Matthew Kocher <mkocher@vmware.com>
mkocher
force-pushed
the
otel-exporters-vars
branch
from
cbe2381
to
57e17ea
Compare
ctlong
approved these changes
Aug 10, 2023
ctlong
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a moment to review the questions before submitting the PR
WHAT is this change about?
What customer problem is being addressed? Use customer persona to define the problem e.g. Alana is unable to...
CF Developers want to be able to set metrics exporters easily in pipelines
Please provide any contextual information.
NA
Has a cf-deployment including this change passed cf-acceptance-tests?
Does this PR introduce a breaking change? Please take a moment to read through the examples before answering the question.
Does this PR introduce a new BOSH release into the base cf-deployment.yml manifest or any ops-files?
Does this PR make a change to an experimental or GA'd feature/component?
Please provide Acceptance Criteria for this change?
bosh int /tmp/cf.yml -o ./operations/experimental/add-otel-collector.yml -l ./operations/example-vars-files/vars-override-otel-collector-exporters.ymlShould result in a valid manifest with the file exporter configured
What is the level of urgency for publishing this change?