Consolidate VMs (implements #173) #201
Conversation
emalm
commented
Aug 10, 2017
•
emalm
commented
- Moves ssh_proxy job to router instance-group
- Moves cc_uploader job to api instance-group
- Moves file_server job to api instance-group
- Consolidates remaining jobs from cc-bridge, cc-clock, and diego-brain instance-groups (cloud_controller_clock; nsync and tps; auctioneer) on new scheduler instance-group
|
Hey ematpl! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/150122798 The labels on this github issue will be updated when the story is started. |
emalm
force-pushed
the
vm-consolidation
branch
from
b87a838
to
29cb2cb
Compare
|
Hey @ematpl, thanks for the PR. I'll prioritize it to get reviewed, but it might not be for a week or two, since we're focusing on uptime measurements right now. Do you need this PR to get merged more quickly than that? |
|
Thanks, @dsabeti, this isn't urgent by any means. I just got a bee in my bonnet about it yesterday evening and drove it out. |
emalm
force-pushed
the
vm-consolidation
branch
2 times, most recently
from
6b01dd0
to
caad076
Compare
|
@ematpl looks like there is an issue with the ops file unit tests, can you take a look and update this pr so that the check passes? |
|
Sure thing, @selzoc. How do I run those unit tests locally? I don't see anything about how to do that in https://github.com/cloudfoundry/cf-deployment/tree/develop#contributing. |
|
@ematpl Thanks for pointing our our doc gap! We just added most of these yesterday and hooked them up to github. Please check the document now and let me know if it's unclear. |
|
Thanks, @selzoc ! Looks good, I'll try out the test script. |
emalm
force-pushed
the
vm-consolidation
branch
2 times, most recently
from
9d0b72a
to
5bdb4c7
Compare
|
@selzoc Units have now passed on the latest commit. |
emalm
force-pushed
the
vm-consolidation
branch
4 times, most recently
from
4df6fc7
to
9c3393c
Compare
emalm
force-pushed
the
vm-consolidation
branch
3 times, most recently
from
f0fa59b
to
38dadbd
Compare
emalm
force-pushed
the
vm-consolidation
branch
from
38dadbd
to
b48057f
Compare
emalm
force-pushed
the
vm-consolidation
branch
3 times, most recently
from
687d47b
to
2b8b3b8
Compare
emalm
force-pushed
the
vm-consolidation
branch
2 times, most recently
from
5f06a0a
to
275d205
Compare
- Moves ssh_proxy job to router instance-group - Moves cc_uploader job to api instance-group - Moves file_server job to api instance-group - Consolidates remaining jobs from cc-bridge, cc-clock, and diego-brain instance-groups (cloud_controller_clock; nsync and tps; auctioneer) on new scheduler instance-group
emalm
force-pushed
the
vm-consolidation
branch
from
275d205
to
cf0ee3f
Compare
|
Thanks, @selzoc ! |
