Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Add ability to cf push buildpack apps #63

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Add ability to cf push buildpack apps #63

merged 9 commits into from
Mar 18, 2020

Conversation

selzoc
Copy link
Member

@selzoc selzoc commented Mar 12, 2020 •
edited
Loading

Please take a moment to review the questions before submitting the PR

🚫 We only accept PRs to develop branch. If this is an exception, please specify why 🚫

WHAT is this change about?

cf push! !!! 🎉

Please merge, test it out, and give us lots of feedback!

Known issues:

  • uses cloudfoundry/cnb:bionic builder image, with the buildpacks included listed here
  • unknown scaling characteristics
  • logs do not appear to stream for staging yet
  • service account used for the cloud controller is currently overly-scoped as a cluster admin
  • only supports apps with a single web process

Please provide any contextual information.

Important: see https://github.com/cloudfoundry/capi-k8s-release#configuring-pushes-of-buildpack-apps for how to configure your k8s endpoint and registry location/creds

Handy thing: to see the progress of the staging process, check the logs of the capi-kpack-watcher pod.

Have you read the contributing guidelines?

  • YES
  • NO

Does this PR introduce a new ytt library?

  • YES - please specify
  • NO

Please provide Acceptance Criteria for this change?

cf push of buildpack apps works

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

@cloudfoundry/cf-capi

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171772085

The labels on this github issue will be updated when the story is started.

@cf-rel-int-status-bot
Copy link

Hello friend, it looks like your pull request has failed one or more of our checks. Please take a look! 👀

@jamespollard8
Copy link
Contributor

Reviewing this PR and testing it is a top priority for our team today (Release Integration)

@pivotaljohn
Copy link
Contributor

Following the deployment instructions given, Release Integration was not able to verify the cloud-native buildpack configuration was working.

See thread on #cf-for-k8s for details.

Once we enable the CAPI diego_docker feature (i.e. cf enable-feature-flag diego_docker), then apps build and deploy, as expected. This was observed to work with both CF CLI v6.50 and CF CLI v7.0.0-beta.30.

Release Integration will document this additional step for the time being.

selzoc and others added 3 commits March 17, 2020 10:41
@selzoc @davewalter
Allow plaintext connections to cf-blobstore
4e87b76
@davewalter
Bump capi-k8s-release to support cf push
3120354 
- Deploy capi-kpack-watcher component
  - Includes new UAA client for it to talk to capi api with
- Run custom nginx on api server pod that handles package uploads
- Add local worker to api server pod to transfer packages to the
blobstore
- Allow configuration of kpack to push built app images to a registry
@selzoc @davewalter
Bump vendir reference for capi-k8s-release
f060f95 
[#171387580]

Co-authored-by: Jaskanwal Pawar <jpawar@pivotal.io>
Co-authored-by: Chris Selzo <cselzo@pivotal.io>
@pivotaljohn
Copy link
Contributor

Rebased this PR on develop so that documentation changes we're about to apply on top of this PR are up-to-date.

@selzoc
Copy link
Member Author

selzoc commented Mar 17, 2020

also fyi created this story so we don't need to enable the diego_docker feature flag for cf-for-k8s: https://www.pivotaltracker.com/story/show/171830993

davewalter and others added 6 commits March 18, 2020 11:02
@davewalter @pivotaljohn
Generate kpack config from GCP Service Account JSON
d104b27 
[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter @pivotaljohn
Remove Table of Contents, for now, for better UX
2c36e30 
The UX is confusing when the total page size is smaller than the typical
screen height.

Removing the TOC for now so that today's users have a better experience.
If/When the page becomes longer, let's restore this.

[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter @pivotaljohn
Document enabling Cloud Native Buildpacks
5132ca7 
[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter @pivotaljohn
Clarify that the hack scripts are not supported
9caf9bc 
[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter @pivotaljohn
Merge branch 'wip-kube-local-workers--relint-additions' into wip-kube…
450fd61 
…-local-workers

[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter @pivotaljohn
Add an overlay to pin the cnb image
f031947 
... to something compatible with the current version of kpack

[#171808167](https://www.pivotaltracker.com/story/show/171808167)

Co-authored-by: John Ryan <jryan@pivotal.io>
@davewalter davewalter merged commit c6039e0 into develop Mar 18, 2020
@davewalter davewalter deleted the wip-kube-local-workers branch March 18, 2020 18:55
@rosenhouse
Copy link

🎉

@pivotaljohn pivotaljohn mentioned this pull request Mar 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davewalter davewalter davewalter left review comments

@cppforlife cppforlife cppforlife left review comments

@zankich zankich zankich left review comments

@nthomson-pivotal nthomson-pivotal nthomson-pivotal left review comments

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@selzoc @cf-gitbot @cf-rel-int-status-bot @jamespollard8 @pivotaljohn @rosenhouse @davewalter @cppforlife @zankich @nthomson-pivotal