Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

added wait_timout and innodb_force_primary_key #220

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nbari
Copy link

@nbari nbari commented Nov 30, 2018

Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.

Feature or Bug Description

What does this PR change?
added option to configure wait_timeout and innodb_force_primary_key

Motivation

The default value for wait_timeout is 8 hours which lead to a problem of reaching the defined max_connections to fast if the applications are not closing the connection after using them or if they create an unlimited pool connection that must of the time is in sleep mode and just consuming connections.

The innodb_force_primary_key is to prevent extra load in the cluster more details here https://jira.mariadb.org/browse/MDEV-5335

Related Issue

#197

@cfdreddbot
Copy link

❌ Hey nbari!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @nbari is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162338019

The labels on this github issue will be updated when the story is started.

@ldangeard-orange
Copy link
Contributor

Hello @nbari
The description of innodb_force_primary_key in jobs/mysql/spec is wrong ,

  • it's not The number of seconds the server waits for activity on an interactive connection before closing it'

  • but If set to true (false is default) CREATE TABLEs without a primary or unique key where all keyparts are NOT NULL will not be accepted, and will return an error.

@nbari
Copy link
Author

nbari commented Dec 17, 2018

@ldangeard-orange thanks for the heads up, just fixed 👍

@andrewgilbert12
Copy link
Contributor

Hi @nbari, if you could please sign the CLA and reopen the PR as described above, we will look into this, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants