bosh-dns-adapter/sdcclient: delay retries #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We experienced pathological retry behaviour from bosh-dns-adapter when talking to the service-discovery-controller If a request did not return 200 it immediately retried without any delay or backoff This caused a spike in load that then cascaded to another instance of service-discovery-controller Adding a 0/500/1000 delay with jitter, to reduce the risk of cascading failure Signed-off-by: toby lorne <toby@toby.codes>
|
Hey @tlwr , Thanks for the PR! We ran your branch locally and tests pass, so we'll merge this and run it through our pipelines. We will let you know how that goes, and eventually when it is ready to release. |
tlwr
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Jul 7, 2020
silk and cf-networking are released together cf-networking 2.31 contains: cloudfoundry/cf-networking-release#80 cloudfoundry/cf-networking-release#81 which were from our recent dns outage and cloudfoundry/cf-networking-release#76 which has caused one (1) support ticket in the past Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
tlwr
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Jul 7, 2020
silk and cf-networking are released together cf-networking 2.31 contains: cloudfoundry/cf-networking-release#80 cloudfoundry/cf-networking-release#81 which were from our recent dns outage and cloudfoundry/cf-networking-release#78 which has caused one (1) support ticket in the past Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
tlwr
pushed a commit
to alphagov/paas-cf
that referenced
this pull request
Jul 7, 2020
silk and cf-networking are released together cf-networking 2.31 contains: cloudfoundry/cf-networking-release#80 cloudfoundry/cf-networking-release#81 which were from our recent dns outage and cloudfoundry/cf-networking-release#78 which has caused one (1) support ticket in the past Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Introduce a delay between bosh-dns-adapter retries, to reduce the risk of denial-of-service
Context
See alphagov/paas-cf#2358 for more context
We experienced pathological retry behaviour from bosh-dns-adapter when talking to the service-discovery-controller
If a request did not return 200 it immediately retried without any delay or backoff
This caused a spike in load that then cascaded to another instance of service-discovery-controller
Adding a 0/500/1000 delay with jitter, to reduce the risk of cascading failure
Checklist