-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URI.encode deprecation warnings for Ruby 3 compatibility #73
Conversation
We chose to use the Addressable gem rather than the stdlib's CGI.escape method because Addressable conforms better to the RFC-3896 spec, which was the issue with URI.encode. Co-authored-by: Seth Boyles <sboyles@pivotal.io> Co-authored-by: Tom Viehman <tviehman@pivotal.io>
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/180829543 The labels on this github issue will be updated when the story is started. |
This addresses #68 |
I've pushed some more adjustments in order to remove warnings when running unit tests. @strehle, could you please review and merge this PR? |
I can merge - no matter, but I cannot release to rubygems, so @peterhaochen47 @bruce-ricard either you have the key to do a release or do you know where in pipeline there is a ship-it ? I will join next WG status meeting on thursday, but we need some colleague(s) from vmware |
@tjvman I think Markus has covered the organisational challenge around publishing a new version of this Gem. This is certainly still in the hands of VMware even though other members of the CFF Working Group like SAP (which I'm part of) should also have the ability to cut new releases. Anyway, cutting a new version of this Gem is a major step in order to get proper Ruby 3 support into And we are very close to it, as I've pushed the tested code in cloudfoundry/cf-uaac#95. |
… required 'ci/reporter/rake/rspec' file
21945fc
to
3b43013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment, rest ok
Unit tests passed against Ruby 2.7.2 and Ruby 3.0.3.