Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CF Local to v0.19.0 #218

Merged
merged 1 commit into from Mar 21, 2018
Merged

Update CF Local to v0.19.0 #218

merged 1 commit into from Mar 21, 2018

Conversation

sclevine
Copy link
Contributor

No description provided.

@cfdreddbot
Copy link

Hey sclevine!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156112416

The labels on this github issue will be updated when the story is started.

@sclevine
Copy link
Contributor Author

sclevine commented Mar 20, 2018

This is blocking a release announcement for an already released version. Also, if users see the github release for v0.19.0 and runcf install-plugin cflocal, they will get an older version of the plugin and may be confused about missing features.

In the future, would it be okay for me to open this PR before making a release of CF Local, and then publish the release once the PR is merged?

Alternatively, I have write access to this repo. Are there still manual steps in the process that would prevent me from setting up a pipeline to update the plugin automatically?
(context: /pull/118)

@XenoPhex
Copy link
Contributor

We'd prefer you make the PR after the plugin is released as the internal tests for the deploy try and download the assets to confirm that the SHA1s are correct.

Feel free to automate your release as long as it's submitting a PR and not commiting directly to master. Since it's still the CLI Team's responsibility to maintain this project and it's PRs, we'd prefer anyone who is not an explicit team member to submit changes via PR.

@sclevine
Copy link
Contributor Author

We'd prefer you make the PR after the plugin is released as the internal tests for the deploy try and download the assets to confirm that the SHA1s are correct.

Got it, I'll make sure assets are available before opening the PR, and just hold off on publishing the release notes.

Feel free to automate your release as long as it's submitting a PR and not commiting directly to master. Since it's still the CLI Team's responsibility to maintain this project and it's PRs, we'd prefer anyone who is not an explicit team member to submit changes via PR.

Got it, apologies, I got a different impression from Dies. Future versions of CF Local will likely be self-updating, and that should reduce the friction. Most of the code has already moved into Docker containers anyways.

@XenoPhex XenoPhex merged commit 58a7b8a into cloudfoundry:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants