strings.TrimLeft is used instead of TrimPrefix

[GrosQuildu]

Please fill out the issue checklist below and provide ALL the requested information.

• I reviewed open and closed github issues that may be related to my problem.
• I tried updating to the latest version of the CF CLI to see if it fixed my problem.
• I attempted to run the command with CF_TRACE=1 to help debug the issue.
• I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with

In the getFilenameFromHeader method the "filename=" string is a cutset (a set of characters) to be removed, and not a prefix.

cli/cf/util/downloader/file_download.go

Lines 90 to 105 in b5a352a

	func getFilenameFromHeader(h string) string {
	if h == "" {
	return ""
	}
	contents := strings.Split(h, ";")
	for _, content := range contents {
	if strings.Contains(content, "filename=") {
	content = strings.TrimSpace(content)
	name := strings.TrimLeft(content, "filename=")
	return strings.Trim(name, `"`)
	}
	}
	return ""
	}

Fixed function should be like this:

 func getFilenameFromHeader(h string) string { 
 	if h == "" { 
 		return "" 
 	} 
  
 	contents := strings.Split(h, ";") 
 	for _, content := range contents { 
                content = strings.TrimSpace(content) 
 		if strings.HasPrefix(content, "filename=") { 
 			name := strings.TrimPrefix(content, "filename=") 
 			return strings.Trim(name, `"`) 
 		} 
 	} 
  
 	return "" 
 } 

Exact Steps To Reproduce

Changing line below to "Content-Disposition": []string{"attachment; filename=ameno.zip"},

cli/cf/util/downloader/file_download_test.go

Line 85 in b5a352a

"Content-Disposition": []string{"attachment; filename=header.zip"},

and line below to Expect(name).To(Equal("ameno.zip"))

cli/cf/util/downloader/file_download_test.go

Line 111 in b5a352a

Expect(name).To(Equal("header.zip"))

will make the test fail.