Incorrect values written to Registry for Inno Installers

[mdanish-kh]

Please fill out the issue checklist below and provide ALL the requested information.

• I reviewed open and closed github issues that may be related to my problem.
• I tried updating to the latest version of the CF CLI to see if it fixed my problem.
• I attempted to run the command with CF_TRACE=1 to help debug the issue.
• I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with

While adding the package in Windows Package Manager (WinGet) microsoft/winget-pkgs#107769, I found that the DisplayVersion written to Registry is incorrect in case of Inno installers. The DisplayVersion written is the raw string VERSION instead of the actual version string. DisplayName also contains the raw string instead of the actual version (but this isn't as important as version being incorrect). Since WinGet relies on metadata from Registry to be the source of accurate information about a given package, WinGet users will fail to know accurate information about the package and may even fail to receive an upgrade if matching logic determines the string VERSION > any given version e.g. 8.6.1

What happened

DisplayVersion and DisplayName keys written to Registry (and visible in Apps&Features / appwiz.cpl) contain the string VERSION instead of the actual version

Expected behavior

DisplayVersion and DisplayName Registry values should contain the actual version string e.g. 8.6.1 for https://github.com/cloudfoundry/cli/releases/tag/v8.6.1

Exact Steps To Reproduce

1. Install x64 / x86 installer from https://github.com/cloudfoundry/cli/releases/tag/v8.6.1
2. Notice the version in appwiz.cpl / Apps&Features / DisplayVersion string in Registry

Provide more context

Happens with both x64 and x86 installers of 8.6.1

[a-b]

Thanks for your input. Please consider making PR, as all release scripts are OSS and located here and here.

It looks like we should do something similar to this