Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order of cf plugins is non-deterministic #923

Closed
voelzmo opened this issue Aug 11, 2016 · 5 comments
Closed

order of cf plugins is non-deterministic #923

voelzmo opened this issue Aug 11, 2016 · 5 comments

Comments

@voelzmo
Copy link

voelzmo commented Aug 11, 2016

Command

cf plugins

CLI Version

$ cf --version
cf version 6.21.1+6fd3c9f-2016-08-10

Error

I'd expect cf plugins to show the same output every time I call it. The order of available commands seems to be somehow random. I don't know what the order criteria should be (probably either Plugin Name or Command Name, maybe in even in that order). It should at least be consistent

$ cf plugins
Listing Installed Plugins...
OK

Plugin Name     Version   Command Name        Command Help
Stack-Changer   1.1.0     stack-change        Update stacks for apps from lucid64 to cflinuxfs2. Restart started apps.
Stack-Changer   1.1.0     stack-list          List all apps running on stack lucid64.
open            1.1.0     open                open app url in browser
open            1.1.0     service-open        open service instance dashboard in browser
usage-report    1.1.0     usage-report        Report AI and memory usage for orgs and spaces
Diego-Enabler   1.2.1     enable-diego        Migrate app to the Diego runtime
Diego-Enabler   1.2.1     disable-diego       Migrate app to the DEA runtime
Diego-Enabler   1.2.1     has-diego-enabled   Report whether an app is configured to run on the Diego runtime
Diego-Enabler   1.2.1     diego-apps          Lists all apps running on the Diego runtime that are visible to the user
Diego-Enabler   1.2.1     dea-apps            Lists all apps running on the DEA runtime that are visible to the user
Diego-Enabler   1.2.1     migrate-apps        Migrate all apps to Diego/DEA

second run

$ cf plugins
Listing Installed Plugins...
OK

Plugin Name     Version   Command Name        Command Help
usage-report    1.1.0     usage-report        Report AI and memory usage for orgs and spaces
Diego-Enabler   1.2.1     enable-diego        Migrate app to the Diego runtime
Diego-Enabler   1.2.1     disable-diego       Migrate app to the DEA runtime
Diego-Enabler   1.2.1     has-diego-enabled   Report whether an app is configured to run on the Diego runtime
Diego-Enabler   1.2.1     diego-apps          Lists all apps running on the Diego runtime that are visible to the user
Diego-Enabler   1.2.1     dea-apps            Lists all apps running on the DEA runtime that are visible to the user
Diego-Enabler   1.2.1     migrate-apps        Migrate all apps to Diego/DEA
Stack-Changer   1.1.0     stack-change        Update stacks for apps from lucid64 to cflinuxfs2. Restart started apps.
Stack-Changer   1.1.0     stack-list          List all apps running on stack lucid64.
open            1.1.0     open                open app url in browser
open            1.1.0     service-open        open service instance dashboard in browser

Platform Details

$ uname -a
Darwin WDFM32386574A 15.6.0 Darwin Kernel Version 15.6.0: Thu Jun 23 18:25:34 PDT 2016; root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64

Shell

iTerm2

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/128135489

The labels on this github issue will be updated when the story is started.

@dkoper
Copy link

dkoper commented Aug 11, 2016

Hi Marco,

I believe the order of commands within the plugin is consistent (I get the same order as you get for Diego-Enabler, trying several runs), which is the same order they're stored in the plugin config file, which I believe is the same order the plugin declares them. I'd like to maintain that order, as plugin authors may be grouping them in some logical order (e.g. enable-diego and disable-diego are paired and followed by the related has-diego-enabled).
We can look at sorting by Plugin Name. Case-insensitive alphabetical order makes sense.
Sounds good?

Regards,
Dies Koper
CF CLI PM

@voelzmo
Copy link
Author

voelzmo commented Aug 11, 2016

Hi Dies,

sounds good to me. Keeping the order that the plugin developer had set can make sense (if that was done on purpose). What mostly threw me off was the different ordering of the plugins on each call.

Warm regards
Marco

@dkoper
Copy link

dkoper commented Sep 24, 2016

Thanks again for your suggestion. We have addressed it in the current release.
https://github.com/cloudfoundry/cli#downloads

Cheers,
Dies Koper
CF CLI PM

@voelzmo
Copy link
Author

voelzmo commented Sep 24, 2016

Verified with CLI 6.22.0+f9f1460-2016-09-23, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants