Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow space application supporter to access specific sidecar endpoints. #2231

Closed
monamohebbi opened this issue Apr 22, 2021 · 0 comments · Fixed by #2343
Closed

Allow space application supporter to access specific sidecar endpoints. #2231

monamohebbi opened this issue Apr 22, 2021 · 0 comments · Fixed by #2343
Assignees
@mariash @mkocher
Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
Milestone
space-application...

Comments

@monamohebbi
Copy link
Contributor

monamohebbi commented Apr 22, 2021 •
edited by mkocher

Issue

Allow space application supporter to access specific sidecar endpoints.

Context

We are introducing a new role and we want to make sure it has the right access.

Expected result

A space application support should be able access the following endpoints:

POST /v3/apps/:guid/sidecars - not doing sidecar post as noted in The Spreadsheet™
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

Acceptance

A space application supporter would see the same info as a space developer assigned to the same space for these and only these sidecar endpoints.

Documentation

When I browse to any of these endpoints on v3 docs I can see the Space Application Supporter role in the list of permitted roles with an indication that this role is not fully implemented and the permissions will be changing.
@monamohebbi monamohebbi added the space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22 label Apr 22, 2021
@monamohebbi monamohebbi added this to To do in Space Supporter via automation Apr 22, 2021
@mariash mariash moved this from To do to In progress in Space Supporter Jun 16, 2021
mkocher added a commit that referenced this issue Jun 16, 2021
@mkocher @mariash
Allow space application supporter to access specific sidecar endpoints
f5f9b88 
allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
@mkocher mkocher mentioned this issue Jun 16, 2021
Merged
5 tasks
@mkocher mkocher moved this from In progress to Acceptance in Space Supporter Jun 16, 2021
mkocher added a commit that referenced this issue Jun 16, 2021
@mkocher @mariash
Allow space application supporter to access specific sidecar endpoints
5b6916f 
allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
@sweinstein22 sweinstein22 linked a pull request Jun 18, 2021 that will close this issue
Allow space application supporter to access specific sidecar endpoints #2343
Merged
5 tasks
mkocher added a commit that referenced this issue Jun 22, 2021
@mkocher @mariash @monamohebbi
Allow space application supporter to access specific sidecar endpoints
a37eae4 
allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
Space Supporter automation moved this from Acceptance to Done Jul 12, 2021
sweinstein22 pushed a commit that referenced this issue Jul 12, 2021
@mkocher @mariash
@galenhammond @MerricdeLauney
Allow space application supporter to access specific sidecar endpoints (
c68146c 
#2343)

* Allow space application supporter to access specific sidecar endpoints

allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

* Refactor tests to match previous patterns.

- We used a more generic term rather than space dev so as not to imply
that this behavior was specific to the space dev.

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
bepotts pushed a commit that referenced this issue Jul 13, 2021
@mkocher @mariash
@galenhammond @MerricdeLauney @bepotts
Allow space application supporter to access specific sidecar endpoints (
8b3783e 
#2343)

* Allow space application supporter to access specific sidecar endpoints

allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

* Refactor tests to match previous patterns.

- We used a more generic term rather than space dev so as not to imply
that this behavior was specific to the space dev.

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
bepotts pushed a commit that referenced this issue Jul 19, 2021
@mkocher @mariash
@galenhammond @MerricdeLauney @bepotts
Allow space application supporter to access specific sidecar endpoints (
c0f4841 
#2343)

* Allow space application supporter to access specific sidecar endpoints

allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

* Refactor tests to match previous patterns.

- We used a more generic term rather than space dev so as not to imply
that this behavior was specific to the space dev.

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
sweinstein22 pushed a commit that referenced this issue Jul 22, 2021
@mkocher @mariash
@galenhammond @MerricdeLauney @monamohebbi
Allow space application supporter to access specific sidecar endpoints (
115be91 
#2343)

* Allow space application supporter to access specific sidecar endpoints

allows access to:
GET /v3/sidecars/:guid
GET /v3/processes/:process_guid/sidecars
GET /v3/apps/:app_guid/sidecars

* Refactor tests to match previous patterns.

- We used a more generic term rather than space dev so as not to imply
that this behavior was specific to the space dev.

Finishes #2231

Co-authored-by: Maria Shaldybin <mariash@vmware.com>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Co-authored-by: Merric de Launey <mdelauney@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariash mariash

@mkocher mkocher

Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
  
Done
Milestone
space-application-supporter
4 participants
@mariash @mkocher @cf-gitbot @monamohebbi