Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure space supporter receives proper error code for specific build endpoints #2397

Closed
monamohebbi opened this issue Jul 13, 2021 · 0 comments · Fixed by #2407
Closed

Ensure space supporter receives proper error code for specific build endpoints #2397

monamohebbi opened this issue Jul 13, 2021 · 0 comments · Fixed by #2407
Assignees
@moleske
Projects
Space Supporter
Milestone
space-application...

Comments

@monamohebbi
Copy link
Contributor

monamohebbi commented Jul 13, 2021 •
edited by ctlong

Issue

Allow space supporter to access specific build endpoints.

Context

We are introducing a new role and we want to make sure it has the right access.

Expected result

A space should get a 403 unauthorized error when trying to curl the following endpoints:

PATCH /v3/builds/:guid

Acceptance

As a space supporter, if I curl the PATCH /v3/builds/:guid endpoint for a build that exists, I receive a 403 error telling me I am not authorized to perform this action.

Documentation

No changes required. We are just aligning with our style guide.
@monamohebbi monamohebbi added this to To do in Space Supporter via automation Jul 13, 2021
@moleske moleske moved this from To do to In progress in Space Supporter Jul 14, 2021
@moleske moleske self-assigned this Jul 14, 2021
moleske added a commit that referenced this issue Jul 14, 2021
@moleske
Return 403 for Space Support on PATCH /v3/builds/:guid
e9d5af7 
closes #2397

Authored-by: Michael Oleske <moleske@pivotal.io>
@moleske moleske mentioned this issue Jul 14, 2021
Merged
5 tasks
@moleske moleske moved this from In progress to Acceptance in Space Supporter Jul 14, 2021
Space Supporter automation moved this from Acceptance to Done Jul 14, 2021
bepotts pushed a commit that referenced this issue Jul 19, 2021
@moleske @bepotts
Return 403 for Space Support on PATCH /v3/builds/:guid
1703554 
closes #2397

Authored-by: Michael Oleske <moleske@pivotal.io>
sweinstein22 pushed a commit that referenced this issue Jul 22, 2021
@moleske @monamohebbi
Return 403 for Space Support on PATCH /v3/builds/:guid
76cc2b9 
closes #2397

Authored-by: Michael Oleske <moleske@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moleske moleske

Labels
None yet
Projects
Space Supporter
  
Done
Milestone
space-application-supporter
Development

Successfully merging a pull request may close this issue.

Return 403 for Space Support on PATCH /v3/builds/:guid cloudfoundry/cloud_controller_ng
3 participants
@cf-gitbot @monamohebbi @moleske