Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure space supporter receives proper error code for specific manifest endpoints #2398

Closed
monamohebbi opened this issue Jul 13, 2021 · 0 comments · Fixed by #2412
Closed

Ensure space supporter receives proper error code for specific manifest endpoints #2398

monamohebbi opened this issue Jul 13, 2021 · 0 comments · Fixed by #2412
Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
Milestone
space-application...

Comments

@monamohebbi
Copy link
Contributor

monamohebbi commented Jul 13, 2021 •
edited by ctlong

Context

We are introducing a new role and we want to make sure it has the right access.

Expected result

A space should get a 403 unauthorized error when trying to curl the following endpoints:

POST /v3/spaces/:guid/actions/apply_manifest
GET /v3/apps/:guid/manifest
POST /v3/spaces/:guid/manifest_diff

Acceptance

As a space supporter, if I curl the any of the above endpoints for an app and space that exist, providing a valid manifest, I receive a 403 error telling me I am not authorized to perform this action.

Documentation

No changes required. We are just aligning with our style guide.
@monamohebbi monamohebbi added the space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22 label Jul 13, 2021
@monamohebbi monamohebbi added this to To do in Space Supporter via automation Jul 13, 2021
@mkocher mkocher moved this from To do to In progress in Space Supporter Jul 15, 2021
mkocher added a commit that referenced this issue Jul 15, 2021
@mkocher @ctlong
Ensure space supporter receives error for specific manifest endpoints (…
664d607 
…#2398)

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Carson Long <lcarson@vmware.com>
@ctlong ctlong mentioned this issue Jul 15, 2021
Merged
5 tasks
@ctlong ctlong moved this from In progress to Acceptance in Space Supporter Jul 15, 2021
Space Supporter automation moved this from Acceptance to Done Jul 16, 2021
bepotts pushed a commit that referenced this issue Jul 19, 2021
@mkocher @ctlong @bepotts
Ensure space supporter receives error for specific manifest endpoints (…
b3d4e06 
…#2398)

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Carson Long <lcarson@vmware.com>
sweinstein22 pushed a commit that referenced this issue Jul 22, 2021
@mkocher @ctlong @monamohebbi
Ensure space supporter receives error for specific manifest endpoints (…
ce56a55 
…#2398)

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Carson Long <lcarson@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
  
Done
Milestone
space-application-supporter
4 participants
@mkocher @cf-gitbot @monamohebbi @ctlong