Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure space supporter receives proper error code for specific deployments endpoints #2399

Closed
monamohebbi opened this issue Jul 14, 2021 · 0 comments · Fixed by #2414
Closed

Ensure space supporter receives proper error code for specific deployments endpoints #2399

monamohebbi opened this issue Jul 14, 2021 · 0 comments · Fixed by #2414
Assignees
@mkocher @galenhammond
Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
Milestone
space-application...

Comments

@monamohebbi
Copy link
Contributor

monamohebbi commented Jul 14, 2021 •
edited by ctlong

Context

We are introducing a new role and we want to make sure it has the right access.

Expected result

A space should get a 403 unauthorized error when trying to curl the following endpoints:

PATCH /v3/deployments/:guid

Acceptance

As a space supporter, if I curl the PATCH /v3/deployments/:guid endpoint for a build that exists, I receive a 403 error telling me I am not authorized to perform this action.

Documentation

No changes required. We are just aligning with our style guide.
@monamohebbi monamohebbi added the space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22 label Jul 14, 2021
@monamohebbi monamohebbi added this to To do in Space Supporter via automation Jul 14, 2021
@galenhammond galenhammond moved this from To do to In progress in Space Supporter Jul 16, 2021
galenhammond added a commit that referenced this issue Jul 16, 2021
@mkocher @galenhammond
Space supporter receives a 403 for v3/deployments/:guid
383dc84 
Closes #2399

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Galen Hammond <galenh@vmware.com>
@galenhammond galenhammond mentioned this issue Jul 16, 2021
Merged
5 tasks
@galenhammond galenhammond moved this from In progress to Acceptance in Space Supporter Jul 16, 2021
galenhammond added a commit that referenced this issue Jul 16, 2021
@mkocher @galenhammond
Space supporter receives a 403 for v3/deployments/:guid
67c42ef 
Closes #2399

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Space Supporter automation moved this from Acceptance to Done Jul 16, 2021
bepotts pushed a commit that referenced this issue Jul 19, 2021
@mkocher @galenhammond @bepotts
Space supporter receives a 403 for v3/deployments/:guid
5c9d4b2 
Closes #2399

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Galen Hammond <galenh@vmware.com>
sweinstein22 pushed a commit that referenced this issue Jul 22, 2021
@mkocher @galenhammond @monamohebbi
Space supporter receives a 403 for v3/deployments/:guid
6ee5068 
Closes #2399

Co-authored-by: Matthew Kocher <mkocher@pivotal.io>
Co-authored-by: Galen Hammond <galenh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkocher mkocher

@galenhammond galenhammond

Labels
space-application-supporter https://github.com/cloudfoundry/cfar-proposals/issues/22
Projects
Space Supporter
  
Done
Milestone
space-application-supporter
Development

Successfully merging a pull request may close this issue.

Space supporter receives a 403 for v3/deployments/:guid cloudfoundry/cloud_controller_ng
4 participants
@mkocher @cf-gitbot @monamohebbi @galenhammond